-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3) : Bump the dependencies group with 5 updates #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated backport to the branch(3) branch, primarily focused on updating a group of five dependencies. The aim is to keep the project's dependencies up-to-date, ensuring compatibility, security, and leveraging the latest features from these libraries.
Highlights
- Dependency Updates: Five key dependencies have been updated to their latest versions to ensure the
branch(3)branch remains current and stable. - Azure Cosmos DB Driver: The
azureCosmosVersionhas been bumped from4.72.0to4.73.1. - Oracle JDBC Driver: The
oracleDriverVersionhas been updated from23.8.0.25.04to23.9.0.25.07. - SQLite JDBC Driver: The
sqliteDriverVersionhas been updated from3.50.2.0to3.50.3.0. - Apache Commons Text: The
commonsTextVersionhas been bumped from1.13.1to1.14.0. - JUnit 5: The
junitVersionhas been updated from5.13.3to5.13.4.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated backport to update five dependency versions. While the changes seem straightforward, my review found that four of the five new versions for Oracle JDBC, SQLite JDBC, Apache Commons Text, and JUnit do not exist in the configured Maven Central repository. This is a critical issue that will likely cause build failures and needs to be addressed to ensure the project remains buildable for all contributors. Also, the azureCosmosVersion may have compatibility issues.
| azureCosmosVersion = '4.73.1' | ||
| jooqVersion = '3.14.16' | ||
| awssdkVersion = '2.32.2' | ||
| commonsDbcp2Version = '2.13.0' | ||
| mysqlDriverVersion = '8.4.0' | ||
| postgresqlDriverVersion = '42.7.7' | ||
| oracleDriverVersion = '23.8.0.25.04' | ||
| oracleDriverVersion = '23.9.0.25.07' | ||
| sqlserverDriverVersion = '12.8.1.jre8' | ||
| sqliteDriverVersion = '3.50.2.0' | ||
| sqliteDriverVersion = '3.50.3.0' | ||
| yugabyteDriverVersion = '42.7.3-yb-4' | ||
| db2DriverVersion = '12.1.2.0' | ||
| mariadDbDriverVersion = '3.5.4' | ||
| picocliVersion = '4.7.7' | ||
| commonsTextVersion = '1.13.1' | ||
| junitVersion = '5.13.3' | ||
| commonsTextVersion = '1.14.0' | ||
| junitVersion = '5.13.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several of the updated dependency versions in this change do not appear to exist in Maven Central, which is the only repository configured in the build script. This will likely cause the build to fail.
Specifically:
azureCosmosVersion:azure-cosmosversion4.73.1may have compatibility issues with other dependencies.oracleDriverVersion:ojdbc8version23.9.0.25.07is not on Maven Central. The23.xversions are typically forojdbc11.sqliteDriverVersion:sqlite-jdbcversion3.50.3.0is not on Maven Central. The latest public version is3.46.0.0.commonsTextVersion:commons-textversion1.14.0is not on Maven Central. The latest public version is1.12.0.junitVersion:junit-bomversion5.13.4is not on Maven Central. The latest public version is5.10.2.
If these dependencies are sourced from a private repository, it should be declared in the build configuration for reproducibility. Could you please verify these version numbers?
This is an automated backport of the following:
Please merge this PR after all checks have passed.